Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_committer_and_os_cli): change os hint test return type & rename #4132

Conversation

amosStarkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@amosStarkware amosStarkware marked this pull request as ready for review February 13, 2025 10:32
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

@amosStarkware amosStarkware force-pushed the 02-13-fix_starknet_committer_and_os_cli_added_missing_hints_from_vm_with_a_few_changes_see_comments_ branch from f1d4f0d to 11fb657 Compare February 13, 2025 11:21
@dafnamatsry dafnamatsry changed the base branch from 02-13-fix_starknet_committer_and_os_cli_added_missing_hints_from_vm_with_a_few_changes_see_comments_ to main February 13, 2025 12:04
@amosStarkware amosStarkware force-pushed the chore_starknet_committer_and_os_cli_change_os_hint_test_return_type_rename_it branch from 5e1ce05 to ab236e0 Compare February 13, 2025 12:09
Copy link

graphite-app bot commented Feb 13, 2025

Merge activity

  • Feb 13, 7:10 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.090 ms 35.587 ms 36.165 ms]
change: [+1.4907% +3.0550% +4.9223%] (p = 0.00 < 0.05)
Performance has regressed.
Found 18 outliers among 100 measurements (18.00%)
10 (10.00%) high mild
8 (8.00%) high severe

@amosStarkware amosStarkware added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 76c640e Feb 13, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants