Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): urn sudo in the first step of the integration test #4141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Feb 13, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


scripts/sequencer_integration_test.sh line 31 at r1 (raw file):

# Stop any running instances of starknet_sequencer_node (ignore error if not found)
sudo killall starknet_sequencer_node 2>/dev/null

placeholder

Code quote:

equencer_

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


scripts/sequencer_integration_test.sh line 31 at r1 (raw file):

# Stop any running instances of starknet_sequencer_node (ignore error if not found)
sudo killall starknet_sequencer_node 2>/dev/null

Please use sudo -v at the top, with a clear message beforehand (something like "this script needs sudo permissions")

Code quote:

sudo killall starknet_sequencer_node 2>/dev/null

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


scripts/sequencer_integration_test.sh line 31 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please use sudo -v at the top, with a clear message beforehand (something like "this script needs sudo permissions")

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants