-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_integration_tests): urn sudo in the first step of the integration test #4141
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
scripts/sequencer_integration_test.sh
line 31 at r1 (raw file):
# Stop any running instances of starknet_sequencer_node (ignore error if not found) sudo killall starknet_sequencer_node 2>/dev/null
placeholder
Code quote:
equencer_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
scripts/sequencer_integration_test.sh
line 31 at r1 (raw file):
# Stop any running instances of starknet_sequencer_node (ignore error if not found) sudo killall starknet_sequencer_node 2>/dev/null
Please use sudo -v
at the top, with a clear message beforehand (something like "this script needs sudo permissions")
Code quote:
sudo killall starknet_sequencer_node 2>/dev/null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
scripts/sequencer_integration_test.sh
line 31 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please use
sudo -v
at the top, with a clear message beforehand (something like "this script needs sudo permissions")
Done.
…integration test commit-id:d62fe262
b59e891
to
2d5cce3
Compare
No description provided.