Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): TE-2448 added namespace config tab in configuration page #1604

Merged
merged 7 commits into from
Nov 8, 2024
Merged

feat(ui): TE-2448 added namespace config tab in configuration page #1604

merged 7 commits into from
Nov 8, 2024

Conversation

nalin-patidar
Copy link
Collaborator

Issue(s)

https://startree.atlassian.net/browse/TE-2448

Description

Users can configure the notification time format and timezone.

@nalin-patidar nalin-patidar requested a review from a team as a code owner October 18, 2024 12:09
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:27am

@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Oct 18, 2024
@cyrilou242
Copy link
Collaborator

not sure if I understand this correctly but this should call
GET workspace-configuration
PUT workspace-configuration

@nalin-patidar
Copy link
Collaborator Author

nalin-patidar commented Oct 24, 2024 •
edited by jira bot
Loading

not sure if I understand this correctly but this should call GET workspace-configuration PUT workspace-configuration

@cyrilou242 I haven't added the API integration. If we are fine with exposing the format and timezone update via a string with no validation on format, I can go ahead and integrate the API.
I was under the impression we will wrap this up in one go as part of this ticket(TE-2488). Let me know how should I proceed.

cyrilou242
cyrilou242 requested changes Nov 8, 2024
View reviewed changes
thirdeye-ui/src/app/rest/dto/workspace.interfaces.ts Show resolved Hide resolved
thirdeye-ui/src/app/locale/languages/en-us.json Outdated
@@ -630,6 +632,7 @@
"weeks-lowercase": "weeks",
"what-went-wrong-and-where": "What went wrong and where?",
"whole-alert": "Whole alert",
"workspace-config": "workspace config",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is user facing right ?
should we use Settings instead also here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me change it to settings

@cyrilou242 cyrilou242 self-requested a review November 8, 2024 10:27
cyrilou242
cyrilou242 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@cyrilou242 cyrilou242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@nalin-patidar nalin-patidar merged commit 22d1dec into master Nov 8, 2024
12 checks passed
@nalin-patidar nalin-patidar deleted the te-2448 branch November 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilou242 cyrilou242 cyrilou242 approved these changes

Assignees
No one assigned
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalin-patidar @cyrilou242