Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): TE-XX added close button to the alert subscription group popup #1626

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix(ui): TE-XX added close button to the alert subscription group popup #1626

merged 2 commits into from
Nov 4, 2024

Conversation

harshilvelotio
Copy link
Collaborator

Issue(s)

Description

  • Added

Checklist

  • if queries to the database are changed: think about query performance and indexes

Screenshots

close-button.mp4

How to test

List steps to reproduce the issue(s) and test the change, if required.

@harshilvelotio harshilvelotio requested a review from a team as a code owner October 25, 2024 05:05
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 0:41am

@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Oct 25, 2024
@harshilvelotio harshilvelotio merged commit 54bfb0a into master Nov 4, 2024
11 of 12 checks passed
@harshilvelotio harshilvelotio deleted the harshil/fix-alert-popup-behaviour branch November 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalin-patidar nalin-patidar nalin-patidar approved these changes

Assignees
No one assigned
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshilvelotio @nalin-patidar