-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] upgrade to java 21 #1655
Open
cyrilou242
wants to merge
10
commits into
master
Choose a base branch
from
te-2526-upgrade-to-java-21
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyrilou242
force-pushed
the
te-2526-upgrade-to-java-21
branch
from
November 15, 2024 10:36
8ef9765
to
da20a20
Compare
anshul98ks123
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks:
./mvnw clean install
How to review:
look commit per commit
Ref:
https://nipafx.dev/road-to-21-upgrade/
dropwizard is tested on java 21: dropwizard/dropwizard#8173
https://www.baeldung.com/java-lts-21-new-features
Note 1:
virtual threads may have an impact on the performance/behavior of the system.
this PR does not directly introduce virtual threads usage.
by default, dropwizard does not use virtual threads either: https://www.dropwizard.io/en/stable/manual/configuration.html
the dropwizard virtual threads toggle will be exposed in another PR
Note 2:
java 21 adds support for generational ZGC.
https://openjdk.org/jeps/439
It's likely it will improve the performance of the evaluate endpoint.
This is not in the scope of this PR.