Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] upgrade to java 21 #1655

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

cyrilou242
Copy link
Collaborator

@cyrilou242 cyrilou242 commented Nov 15, 2024

  • [java] upgrade github actions to java 21
  • [java] upgrade DockerFile to java 21
  • [java] update readme to java 21
  • [java] upgrade benchmark compilation target to java 21

Checks:

  • ./mvnw clean install
  • able to build the Docker image
  • able to launch the thirdeye-distribution

How to review:
look commit per commit

Ref:
https://nipafx.dev/road-to-21-upgrade/
dropwizard is tested on java 21: dropwizard/dropwizard#8173
https://www.baeldung.com/java-lts-21-new-features

Note 1:
virtual threads may have an impact on the performance/behavior of the system.
this PR does not directly introduce virtual threads usage.
by default, dropwizard does not use virtual threads either: https://www.dropwizard.io/en/stable/manual/configuration.html
the dropwizard virtual threads toggle will be exposed in another PR

Note 2:
java 21 adds support for generational ZGC.
https://openjdk.org/jeps/439
It's likely it will improve the performance of the evaluate endpoint.
This is not in the scope of this PR.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 11:09am

@cyrilou242 cyrilou242 changed the title te 2526 upgrade to java 21 [java] upgrade to java 21 Nov 15, 2024
Copy link
Collaborator

@anshul98ks123 anshul98ks123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants