Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce nix and just for reproducible CI locally #5202

Closed

Conversation

expelledboy
Copy link

@expelledboy expelledboy commented Feb 14, 2025

The goal is to allow dev to quickly become productive, and be able to execute exactly what is run during CI before they submit a PR.

  • Nix Integration:

    • Added .envrc for direnv integration with use flake to load the Nix environment.
    • Introduced flake.nix and flake.lock to define and lock dependencies.
    • Updated .gitignore to include .direnv, which is generated by Direnv and Nix workflow.
  • Just Task Runner:

    • Added justfile to define reproducible commands for tasks such as:
      • init: Installs node dependencies if node_modules does not exist.
      • lint: Runs linting on the codebase.
      • build: Compiles the project.
      • test: Typechecks and tests the project.
      • ci: Comprehensive task that runs init, build, lint, and test stages.
  • Updates to Pre-commit Hook:

    • Added the pre-push hook in package.json to run jest -o. This ensures that only changed files before a remote push.

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 4621294

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist
Copy link
Member

While those tools look useful and all… I think this is a maintenance burden for the core contributors (as far as I know none of us use those tools). This repo is using pretty standard JS tooling and reproducibility has not been a problem so far

@Andarist Andarist closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants