Move to foundry #130
Merged
Move to foundry #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
reviewed
Jun 20, 2024
|
This PR needs adjustment of the deploy script. |
0x-r4bbit
force-pushed
the
foundry-template-test
branch
from
2e00a9c to
1c66a1e
Compare
0x-r4bbit
force-pushed
the
foundry-template-test
branch
from
1c66a1e to
fe54e5f
Compare
0x-r4bbit
reviewed
Jun 21, 2024
| string public constant PARENT_REGISTRY_ENV_KEY = "PARENT_REGISTRY"; | ||
|
|
||
| function run() public returns (UsernameRegistrar registrar, DeploymentConfig deploymentConfig) { | ||
| address parentRegistry = vm.envOr({ name: PARENT_REGISTRY_ENV_KEY, defaultValue: address(0) }); |
There was a problem hiding this comment.
@3esmit With this we can run a migration script via:
PARENT_REGISTRY="0x...." forge script scripts/Deploy.s.sol --rpc-url $RPC_URL
I still kept a runMigration() function for tests.
0x-r4bbit
approved these changes
Jun 21, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.