feat(onboarding): add AC notif for importing old accounts #17078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (42)
|
caybro
reviewed
Jan 15, 2025
ui/app/mainui/activitycenter/views/ActivityNotificationProfileFetching.qml
Outdated
Show resolved
Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationProfileFetching.qml
Outdated
Show resolved
Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationProfileFetching.qml
Show resolved
Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationProfileFetching.qml
Outdated
Show resolved
Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationProfileFetching.qml
Outdated
Show resolved
Hide resolved
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
ee35755 to
a61d968
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
d2d7fe9 to
0e412d4
Compare
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
a61d968 to
6958aa5
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
0e412d4 to
aa5321c
Compare
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
6958aa5 to
a3fcb11
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
2 times, most recently
from
50391c9 to
476e752
Compare
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
a3fcb11 to
4d04bb3
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
35bea58 to
668777f
Compare
alexjba
approved these changes
Jan 24, 2025
| else | ||
| stack.push(loginScreenComponent) | ||
| onboardingFlow.init() | ||
| // if (loginAccountsModel.ModelCount.empty) |
There was a problem hiding this comment.
yeah indeed, it shouldn't be here; probably a bad rebase
There was a problem hiding this comment.
Yeah, sorry I'll rebase in a few
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
668777f to
b14dcf3
Compare
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
4d04bb3 to
2316db0
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
b14dcf3 to
344d28f
Compare
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
2316db0 to
a542a6e
Compare
Fixes #17028 When an old user imports an account, we now fetch the backups in the background and show an AC notification. When the fetch is successful, the AC notif switches to a success message. If after a timeout we detect that we didn't fetch anything or just part, we show an error and the possibility to try again.
jrainville
force-pushed
the
feat/new-onboarding-profile-fetching
branch
from
a542a6e to
7cca187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17028
When an old user imports an account, we now fetch the backups in the background and show an AC notification.
When the fetch is successful, the AC notif switches to a success message.
If after a timeout we detect that we didn't fetch anything or just part, we show an error and the possibility to try again.
Based on top of #17058
Status-go PR: status-im/status-go#6255
Affected areas
Onboarding and AC. In the status-go side, backup handling
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
backup-fetching.webm
@micieslak @caybro if I could request your help please. I managed to make all the states (pending, failure, success), but the badge looks ugly in all but the pending state.
If you could give me a hand in making sure the badge icon looks ok, I'd appreciate. See in the video how the checkmark is way to big for no reason.
Impact on end user
Instead of waiting on a screen for the fetching to work only at the end they could move to the main screen, now they can see the app straight away and data is fetched in the background and shows up when it's ready.
How to test
Risk
Described potential risks and worst case scenarios.
Tick one:
Worst case, the bakcup fetching doesn't work