Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first pass at Environment variable obfuscation #10

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

brendanlensink
Copy link
Collaborator

@brendanlensink brendanlensink commented Mar 30, 2023

(this is the second PR opened, though the first one looks like it was merged I screwed something up and the changes aren't actually in main)

For #6

Adds the --obfuscate tag, which allows you to toggle value obfuscation.

Questions:

  • Do we maybe want to flip the logic here and just obfuscate by default?
  • @nbrooke I tried to google around a little to understand how Swift apps get compiled and what the executable ends up looking like, but wasn't able to get a really satisfying answer, but I'm really curious how secure this actually is?

Like we're providing the salt right in the same file, so theoretically all the information you need to decrypt the values are right there. I know security by obfuscation isn't supposed to be rock solid, but am mostly just curious how much of a different this makes.

# Conflicts:
#	README.md
#	Sources/steamclenv/SteamclEnv.swift
#	SteamclEnv-Example/Environment.swift
#	SteamclEnv-Example/SteamclEnv-Example.xcodeproj/project.pbxproj
@brendanlensink brendanlensink merged commit 00315e7 into main Mar 30, 2023
@brendanlensink brendanlensink deleted the bwl/add-obfuscation branch March 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant