Have DefaultDialog automatically launch Play Store for the user (#14) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reTestUpdatesSupported) * Now responsible for indicating app version, as well as if the build is a development build or a testers build * Allows more control for app to decide how these are determined
…ore if Update is clicked
# Conflicts: # app/src/main/java/com/steamclock/versioncheckkotlinsample/App.kt
ssawchenko
commented
Oct 5, 2021
|
|
||
| // Add the following lines if you want a default alert dialog to handle the displayStates | ||
| // and allow the user to jump out to the Play Store to get updates. | ||
| val upgradeDialog = DefaultUpgradeDialog(versionChecker.displayStateFlow, packageName) |
There was a problem hiding this comment.
Now using same comments and setup in App and Readme for UpgradeDialog
ssawchenko
commented
Oct 5, 2021
| } | ||
|
|
||
| if (canDismiss) { | ||
| setPositiveButton("OK") { _, _ -> | ||
| setNegativeButton("Close") { _, _ -> |
There was a problem hiding this comment.
Changed button wording to imply that action would close dialog
ssawchenko
commented
Oct 5, 2021
| getButton(AlertDialog.BUTTON_NEUTRAL)?.setOnClickListener { | ||
| // todo Proxy out to Play Store. | ||
| getButton(AlertDialog.BUTTON_POSITIVE)?.setOnClickListener { | ||
| launchPlayStorePage() | ||
| } |
There was a problem hiding this comment.
Set BUTTON_POSITIVE instead, since it is the affirmative action
ssawchenko
changed the title
jacobminer
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #14
Summary of Problem:
Update button current does nothing on default dialog handler; would be nice to have it automatically open the Play Store page for the given application when clicked.
Proposed Solution:
DefaultUpgradeDialogtakes packageName and will now attempt to launch the Play Store for that packageTesting Steps:
Launch the sample app and click on the Update button; the Play Store app should launch. Because there is no listing for the sample app this will come up empty, but I tested this out by manually setting the packageName to be one of our public apps and the store page did load.