Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SigningCallback form to allow returning an object #783

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 13, 2024

Closes #780 per discussion in #772 (comment): authorizeEntry can now take a callback that returns an object specifying the signer of the signature so that it isn't implied that it's the address in the entry. Namely, it can return

interface SigningCallbackResult {
  signature: Buffer | Uint8Array;
  publicKey: string;
}

Copy link

github-actions bot commented Nov 13, 2024

Size Change: +2.75 kB (+0.08%)

Total Size: 3.26 MB

Filename Size Change
dist/stellar-base.js 2.39 MB +2.19 kB (+0.09%)
dist/stellar-base.min.js 869 kB +561 B (+0.06%)

compressed-size-action

CHANGELOG.md Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@overcat overcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify authorizeEntry's callback signature to return both the signature and the publicKey.
2 participants