Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation revision #71

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Conversation

noriakis
Copy link
Contributor

The code within R of tidyseurat has been revised to be in line with tidySingleCellExperiment.

In the example for bind_rows and bind_cols, currently ttservice::bind_rows and ttservice::bind_cols are being used. The codes within vignettes and tests are currently not touched. R CMD CHECK passes without errors or warnings.

I would be grateful if you could review the changes.

@stemangiola
Copy link
Owner

The code within R of tidyseurat has been revised to be in line with tidySingleCellExperiment.

In the example for bind_rows and bind_cols, currently ttservice::bind_rows and ttservice::bind_cols are being used. The codes within vignettes and tests are currently not touched. R CMD CHECK passes without errors or warnings.

I would be grateful if you could review the changes.

Another score! Thanks @noriakis!

I don't want to point you to other challenges specifically, as you have already done a lot; if you want to know more, you know when to find me :)

@stemangiola stemangiola merged commit 4c7cde6 into stemangiola:master Aug 25, 2023
2 of 3 checks passed
@noriakis
Copy link
Contributor Author

Thank you very much for merging the PR, and I’m willing to contribute more to this important project!

@stemangiola
Copy link
Owner

Thank you very much for merging the PR, and I’m willing to contribute more to this important project!

Since you took care of the tidyseurat docs, you could replicate for tidySummarizeExperiment and close this challenge!

@noriakis
Copy link
Contributor Author

Thank you for the reply. Happy to do the same for tidySummarizedExperiment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the documentation of tidytranscriptomics adapters, tidySE, tidySCE, tidySPE, tidyseurat
2 participants