Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to dockta #98

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Rename to dockta #98

merged 3 commits into from
Jun 13, 2019

Conversation

beneboy
Copy link
Contributor

@beneboy beneboy commented Jun 12, 2019

As the name suggest, we're rebranding!

The tests that have been skipped were failing in the master branch as well.

@beneboy beneboy requested a review from nokome June 12, 2019 08:30
@codecov-io
Copy link

Codecov Report

Merging #98 into master will decrease coverage by 8.26%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   85.62%   77.36%   -8.27%     
==========================================
  Files          22       22              
  Lines         835      835              
  Branches      115      115              
==========================================
- Hits          715      646      -69     
- Misses        118      188      +70     
+ Partials        2        1       -1
Impacted Files Coverage Δ
src/DockerParser.ts 87.5% <ø> (ø) ⬆️
src/Doer.ts 86.95% <ø> (ø) ⬆️
src/RParser.ts 90.36% <ø> (ø) ⬆️
src/JavascriptParser.ts 96.15% <ø> (ø) ⬆️
src/DockerBuilder.ts 8.91% <0%> (-68.32%) ⬇️
src/NixGenerator.ts 100% <100%> (ø) ⬆️
src/CachingUrlFetcher.ts 100% <100%> (ø) ⬆️
src/Generator.ts 82.27% <100%> (ø) ⬆️
src/RGenerator.ts 93.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138d7c1...e691054. Read the comment docs.

@nokome
Copy link
Member

nokome commented Jun 13, 2019

Thanks @beneboy . I think "renaming" is probably more accurate than "rebranding" for this :). Anyway, I'll put a note in #37 to document the rationale for renaming to our original pre-Twitter poll choice of name.

@nokome nokome merged commit f039a73 into master Jun 13, 2019
@nokome nokome deleted the rename_to_dockta branch June 13, 2019 01:20
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants