Fix FavoritesProvider.ConfirmByLocations

stevencohn · Apr 30, 2024 · 71e946e · 71e946e
1 parent 1a62b10
commit 71e946e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/OneMore/Commands/Favorites/FavoritesProvider.cs b/OneMore/Commands/Favorites/FavoritesProvider.cs
@@ -294,6 +294,15 @@ private async Task<bool> ConfirmByLocation(Favorite favorite)
 			books ??= await one.GetNotebooks();
 
 			var parts = favorite.Location.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
+			if (parts.Length < 3)
+			{
+				// corrupt screentip attribute in XML? (populates Location)
+				// must be at least: /notebook/section/title
+				logger.WriteLine($"invalid favorite location {favorite.Location} [{favorite.Name}]");
+				favorite.Status = FavoriteStatus.Suspect;
+				return false;
+			}
+
 			var notebook = notebooks.Values.FirstOrDefault(n => n.Attribute("name")?.Value == parts[0]);
 			if (notebook == null)
 			{