Improve plotter output, introduce randomness #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
sample
function central to Mafs' plotter.Bug fix: duplicate points, incorrect subdivision
First, it corrects a bug that was causing duplicate points to be evaluated. For example, when sampling the domain [-16, 16] with sampling depth 4, these points were being generated:
Of course, duplicates make no sense here, and we would actually expect a uniform distribution between -16 and 16. Also, we would expect depth 5 to produce 32 segments (33 points), not depth 4. So that was fixed by, thankfully, removing code.
Randomness
Additionally, for quite some time, I have been wanting to introduce some stable randomness to the sampling function, in a way that prevents the function from changing with every render. I finally decided to research that and introduce a pseudo-random hash function when evaluating the midpoint of the domain. This also required the
midpoint
function insample
to become alerp
, since we can no longer simply measure against the midpoint to compute errors.