Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds overload variants for
uuid7
function to vet the return type based on value of argumentas_type
.Unfortunately, this was made possible only by making arguments
as_type
,time_func
,_last
, and_last_as_of
keyword-only. However, I assume this should be fine as:as_type
.With this change:
This change takes in mind that current function documentation referred to use of argument
ns
as positional argument, and as such, argumentns
was exempted from being also keyword-only.Looking forward to hearing any feedback on this, or seeing it merged if the breaking changes are within the acceptable range.