Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional and named arguments in inlining #2801

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Support optional and named arguments in inlining #2801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
29dc3fd
Added changes in 'call'
Nov 23, 2024
23592fb
updates for documentation
Nov 23, 2024
abef8fd
u
Nov 23, 2024
a521faf
u
Nov 24, 2024
aa6f2e6
updates
Nov 24, 2024
87f5172
cleanups
Nov 24, 2024
08cb731
Further cleanups
Nov 24, 2024
c842289
further cleanups + working on coverage test
Nov 24, 2024
0344b47
work on coverage
Nov 24, 2024
3fd04e8
Updates for CI tests
Nov 24, 2024
e9a56aa
intermediate backup
Nov 25, 2024
cf7537e
Merge branch 'martin_nemo' into martin_2_issue_inline_optional_args_2525
Nov 27, 2024
62fa450
Merge branch 'master' into martin_2_issue_inline_optional_args_2525
Nov 28, 2024
6a6b1b3
Merge branch 'master' into martin_2_issue_inline_optional_args_2525
Nov 30, 2024
6ebffae
cleanups
Nov 30, 2024
cfa95aa
bugfix
Dec 4, 2024
6deaea7
Merge branch 'master' into martin_2_issue_inline_optional_args_2525
Jan 13, 2025
3737df5
merge with master
Jan 13, 2025
8f26e80
cleanups
Jan 13, 2025
237f56d
u
Jan 13, 2025
cbb65f0
intermediate commit
Jan 14, 2025
f77715a
coverage test cases
Jan 14, 2025
8651a19
u
Jan 14, 2025
447b147
u
Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,4 @@ src/*.egg-info
.venv
cov.xml
.coverage.*
*.psycache
__pycache__
18 changes: 18 additions & 0 deletions doc/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Please could you add the usual licence/copyright header (with appropriate year).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a comment saying it builds the html versions of all of the docs.

all: developer_guide reference_guide user_guide
.PHONY: developer_guide reference_guide user_guide

developer_guide:
make -C developer_guide html SPHINXOPTS="-W --keep-going"

reference_guide:
make -C reference_guide html SPHINXOPTS="-W --keep-going"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this gives:

build finished with problems, 2 warnings (with warnings treated as errors).
make[1]: *** [Makefile:19: html] Error 1
make[1]: Leaving directory '/home/me/Projects/PSyclone/doc/reference_guide'
make: *** [Makefile:9: reference_guide] Error 2

Possibly the simplest thing to do is not to "treat warnings as errors" for the Reference Guide.


user_guide:
make -C user_guide html SPHINXOPTS="-W --keep-going"

clean:
make -C developer_guide clean
make -C reference_guide allclean
make -C user_guide clean

4 changes: 2 additions & 2 deletions src/psyclone/psyir/nodes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,5 +195,5 @@
'OMPScheduleClause',
'OMPFirstprivateClause',
'OMPSharedClause',
'OMPDependClause'
]
'OMPDependClause',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert (since there's no functional change to this file).

]
Loading
Loading