Add Thor require for StimulusReflex::Installer
#705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for stimulusreflex failed.
|
|
Just to note this change actually broke my app for some reason so this PR obviously still needs work. I'm not sure why it broke yet and this still blocks my deploys. |
juna-nb
force-pushed
the
main
branch
2 times, most recently
from
e1d16a4
to
8291a41
Compare
julianrubisch
requested changes
May 24, 2024
Applications using StimulusReflex were failing during deploys because of the Thor dependency being referenced but not listed as a dependency. This commit adds the require statement to the area of the code that uses it but does not add it as a dependency due to Thor being a dependency of railties already.
marcoroth
changed the title
StimulusReflex::Installer
marcoroth
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rake tasks were failing in projects because the required Thor dependency was not always required, depending on the way it was called.
The fix also needed to explicitly require the thor gem in the installer file that used it as a mixin.
Fixes #701
Why should this be added
Rake tasks in Rails applications were no longer working with the latest version of this Gem.
Checklist