New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for Docker Swarm and other improvements. #11

Merged

peterhuene merged 6 commits into stjude-rust-labs:main from peterhuene:expose-docker-client

Feb 12, 2025

Collaborator

peterhuene commented Feb 11, 2025 •

edited

Loading

This PR implements support for Docker Swarm within the Docker backend.

Additional changes include:

Bumped dependencies to latest.
Implemented a cancellation mechanism so that backends can gracefully cancel
tasks.
Implemented a simple "started" notification callback in backends so that users
of the backends can know when a task has actually started vs. not yet
started.

Before submitting this PR, please make sure:

You have added a few sentences describing the PR here.
You have added yourself or the appropriate individual as the assignee.
You have added at least one relevant code reviewer to the PR.
Your code builds clean without any errors or warnings.
You have added tests (when appropriate).
You have updated the README or other documentation to account for these
changes (when appropriate).
You have added an entry to the relevant CHANGELOG.md (see
"keep a changelog" for more information).
Your commit messages follow the conventional commit style.


          feat: support for Docker Swarm and other improvements.

7da4fe7

This commit implements support for Docker Swarm within the Docker backend.

Additional changes include:

* Bumped dependencies to latest.
* Implemented a cancellation mechanism so that backends can gracefully cancel
  tasks.
* Implemented a simple "started" notification callback in backends so that users
  of the backends can know when a task has actually started vs. not yet
  started.

peterhuene requested a review from claymcleod

February 11, 2025 23:08

peterhuene self-assigned this

claymcleod reviewed

View reviewed changes

crankshaft-docker/src/service.rs Outdated Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Outdated Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Outdated Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Outdated Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/docker.rs Outdated Show resolved Hide resolved

claymcleod reviewed

View reviewed changes

crankshaft-engine/src/service/runner/backend/generic.rs Outdated Show resolved Hide resolved

claymcleod approved these changes

View reviewed changes

Member

claymcleod left a comment

Looks good when the above is addressed.

peterhuene requested a review from claymcleod

February 12, 2025 17:54

peterhuene added 3 commits

February 12, 2025 12:55


          chore: code review feedback.

cbdccac


          chore: update CHANGELOGs.

7b5a2c5


          fix: don't clone input contents for container upload.

15670cb

This fix allows literal input contents to be directly passed in a request to
upload the container rather than cloning it as a `Vec<u8>`.

peterhuene commented

View reviewed changes

crankshaft-engine/src/task/input.rs Show resolved Hide resolved

peterhuene added 2 commits

February 12, 2025 14:19


          fix: make Contents::Literal use a Vec<u8>.

703d1e5


          chore: fix typo.

5b52809

peterhuene merged commit f1af2ac into stjude-rust-labs:main

9 checks passed

peterhuene deleted the expose-docker-client branch

February 12, 2025 19:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet