Feat(share): Add comfirmation email to creator after share was send. #731
Conversation
Added mail confirmation to creator, this means you can now send a bigger share, leave PC and see in mail it was send. This will help to know atleast a mail was send, if creator receives no mail, it will probably not been send to receiver.
|
I dont even know what this mean: |
GitNees
changed the title
GitNees
changed the title
You can just ignore that. These are system tests that will run when I approve the pull requests. Adding a new email shouldn't effect the system tests. |
There was a problem hiding this comment.
Hi, thanks for your contribution.
First of all I would recommend to you to follow the contribution guide to setup the project locally. When the project runs locally you can easily test it.
Additionally, the subject and message should be customizable like the other emails. You can inspire yourself by looking at the other email sending functions. New configuration variables can be added in the backend/prisma/seed/config.seed.ts file. I would also suggest to add a configuration variable that allows the admin to decide whether this email should be sent or not because in my use case I don't want to get a confirmation email.
|
Thats going to be above my level i think... I like the idea to set a confirmation option on or off, but I would not have any idea where, Ill have a look in the code later if I can figure something out, else ill probably close it till someone else can make it happen... But thx for the feedback! |
|
I'll close this for now. Feel free to create a new pull request when you want to work on it again. |
Related to my own request.
Im very new to this and need to figure out a lot, I dont even know how to test it, but looks pretty straightforward.
If I need to do something else, let me know, just trying to add something instead of only requesting:
#714