fix: session duration can't be updated

stonith404 · Aug 19, 2024 · 4780548 · 4780548
1 parent a5dfdd2
commit 4780548
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/backend/internal/model/app_config.go b/backend/internal/model/app_config.go
@@ -16,5 +16,6 @@ type AppConfig struct {
 }
 
 type AppConfigUpdateDto struct {
-	AppName string `json:"appName" binding:"required"`
+	AppName         string `json:"appName" binding:"required"`
+	SessionDuration string `json:"sessionDuration" binding:"required"`
 }
diff --git a/backend/internal/service/app_config_service.go b/backend/internal/service/app_config_service.go
@@ -55,7 +55,7 @@ var defaultDbConfig = model.AppConfig{
 }
 
 func (s *AppConfigService) UpdateApplicationConfiguration(input model.AppConfigUpdateDto) ([]model.AppConfigVariable, error) {
-	savedConfigVariables := make([]model.AppConfigVariable, 10)
+	var savedConfigVariables []model.AppConfigVariable
 
 	tx := s.db.Begin()
 	rt := reflect.ValueOf(input).Type()
@@ -78,7 +78,7 @@ func (s *AppConfigService) UpdateApplicationConfiguration(input model.AppConfigU
 			return nil, err
 		}
 
-		savedConfigVariables[i] = applicationConfigurationVariable
+		savedConfigVariables = append(savedConfigVariables, applicationConfigurationVariable)
 	}
 
 	tx.Commit()

diff --git a/frontend/tests/application-configuration.spec.ts b/frontend/tests/application-configuration.spec.ts
@@ -10,10 +10,14 @@ test('Update general configuration', async ({ page }) => {
 	await page.getByLabel('Session Duration').fill('30');
 	await page.getByRole('button', { name: 'Save' }).first().click();
 
-	await expect(page.getByTestId('application-name')).toHaveText('Updated Name');
 	await expect(page.getByRole('status')).toHaveText(
 		'Application configuration updated successfully'
 	);
+
+	await page.reload();
+
+	await expect(page.getByTestId('application-name')).toHaveText('Updated Name');
+	await expect(page.getByTestId('session-duration')).toHaveText('30');
 });
 
 test('Update application images', async ({ page }) => {