Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make CONTRIBUTING instructions work & fix example envs #152

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

cdanis
Copy link
Contributor

@cdanis cdanis commented Jan 20, 2025

No description provided.

@stonith404
Copy link
Owner

Thanks. PUBLIC_APP_URL doesn't need SSL if it's running on localhost though. And MAXMIND_LICENSE_KEY is not required, if not provided it just won't lookup the IPs

@cdanis
Copy link
Contributor Author

cdanis commented Jan 20, 2025

Thanks. PUBLIC_APP_URL doesn't need SSL if it's running on localhost though.

Does Pocket ID meaningfully operate without SSL? I thought you couldn't add a passkey at all

And MAXMIND_LICENSE_KEY is not required, if not provided it just won't lookup the IPs
Good point, and that might change soon anyway with the custom download url. Will adjust soon

@stonith404
Copy link
Owner

Yeah localhost is the only exception where adding passkeys work without SSL.

@cdanis
Copy link
Contributor Author

cdanis commented Jan 20, 2025

Oh thanks, very good to know. Is it specifically localhost, or localhost as the final domain component, or does it have to do with the resolved IP address?

@stonith404
Copy link
Owner

I'm not sure to be honest but probably the resolved IP.

Locally-delivered resources such as those with http://127.0.0.1 URLs, http://localhost and http://*.localhost URLs (e.g. http://dev.whatever.localhost/), and file:// URLs are also considered to have been delivered securely.

https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts

CONTRIBUTING.md Outdated Show resolved Hide resolved
@cdanis cdanis changed the title docs: tweak CONTRIBUTING & example envs fix: make CONTRIBUTING instructions work & fix example envs Jan 23, 2025
@stonith404 stonith404 merged commit ef1aeb7 into stonith404:main Jan 24, 2025
3 checks passed
@cdanis cdanis deleted the contribs-fix branch January 24, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants