fix: internal schema apprears as object on logout #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SB-harshitajadhav
requested review from
bhaskarsontakke,
prafullaAtSB and
SB-akshaythakar
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SB-akshaythakar
approved these changes
Sep 25, 2024
|
Please add the screenshot for the other usecase like the dropdown contains all the error messages/ showing an Object values |
bhaskarsontakke
approved these changes
Sep 25, 2024
ben-smartbear
requested changes
Sep 30, 2024
SB-akshaythakar
approved these changes
Oct 4, 2024
| }; | ||
| expect(resolvedObject).toEqual(filteredObject); | ||
| }); | ||
| it('show the error if all object contains an error for oneOf', () => { |
There was a problem hiding this comment.
may be you can put a comment saying "The schema marked as internal so it's populate the error object.
SB-akshaythakar
approved these changes
Oct 7, 2024
ben-smartbear
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STOP-1027
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
Previously, if not logged in, the schema which is marked internal showing up in dropdown as an empty 'object' for oneOf/anyOf in public docs.
Before
After
In case of every schema is internal in the list it will display the error message.
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.md