Add plugin typings from DefinitelyTyped #657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @matrosov-nikita for the contribution. I still have to consider this one. In general I would prefer to keep this in an external project that would be referenced by the documentation. An extra bonus would be to find a way to share common types such as ResultSet between Web SQL and this plugin. A further bonus may be to consider wrapping https://github.com/brodybits/sql-promise-helper ref: brody4hire/sql-promise-helper#2 |
This was referenced Dec 19, 2017
brody4hire
pushed a commit
that referenced
this pull request
Apr 18, 2018
Copied from: DefinitelyTyped/DefinitelyTyped#13081 ref: #657
brody4hire
pushed a commit
that referenced
this pull request
Apr 18, 2018
additional documentation items by @brodybits (Christopher J. Brody) ref: #657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.