Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Add more libs to transpile #197

Closed
wants to merge 2 commits into from
Closed

IE11: Add more libs to transpile #197

wants to merge 2 commits into from

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Apr 10, 2021

Issue: #190
Storybook: storybookjs/storybook#12179

@tooppaaa
Copy link
Contributor Author

@shilman, looks like CI si failling. Should we use this to kill this repo and move presets back to main repo ?

@shilman
Copy link
Member

shilman commented Apr 11, 2021

@tooppaaa yes, let's discuss on monday? (or whenever is convenient for you)

@reessm01
Copy link

I integrated his changes locally and was able to get IE11 running. I'm using that as a workaround in the mean time. If this PR needs any support please let me know.

@leepowelldev
Copy link

Not sure if you want to add @pmmmwh/react-refresh-webpack-plugin as I'm seeing ES6 exposed in that package too a of 0.4.3 release. I believe its fixed for the next release though.

@tooppaaa
Copy link
Contributor Author

@leepowelldev I tried adding it but it's injecting code outside of compilation.
It will be resolved in 0.5.x if I'm right which is in beta for the moment.

@shilman, I think we could ship that one ?

@seanparmelee
Copy link

For anyone else interested in this change, it's been moved to an addon: https://storybook.js.org/addons/@storybook/addon-ie11/

@mt9eet
Copy link

mt9eet commented May 29, 2021

I tried adding @storybook/addon-ie11 to my project and it does not seem to work as I'm getting error in the acorn-jsx syntax in IE. I'm just wondering if it's on my end or the addon is not ready 🙂

@seanparmelee
Copy link

I tried adding @storybook/addon-ie11 to my project and it does not seem to work as I'm getting error in the acorn-jsx syntax in IE. I'm just wondering if it's on my end or the addon is not ready 🙂

In my case, it was the color-convert dependency that was causing the problem, but FWIW it looks like acorn-jsx is one of the dependencies that's configured to be transpiled as well: https://github.com/storybookjs/addon-ie11/blob/ef27f126f1e44b31da9c22918a9643ac086f6c1a/src/preset.ts#L42

@tooppaaa
Copy link
Contributor Author

For anyone else interested in this change, it's been moved to an addon: https://storybook.js.org/addons/@storybook/addon-ie11/

Closing.

@tooppaaa tooppaaa closed this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants