Release: Patch 8.5.4 #30459
Open
Release: Patch 8.5.4 #30459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
18 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| yarnPath: ../.yarn/releases/yarn-4.3.0.cjs | ||
| # Sometimes you get a "The remote archive doesn't match the expected checksum" error, uncommenting this line will fix it | ||
| # checksumBehavior: 'update' | ||
| yarnPath: .yarn/releases/yarn-4.6.0.cjs |
There was a problem hiding this comment.
logic: The yarnPath should be relative to the repository root, not the code directory. This should be ../.yarn/releases/yarn-4.6.0.cjs instead of .yarn/releases/yarn-4.6.0.cjs
Suggested change
| yarnPath: .yarn/releases/yarn-4.6.0.cjs | |
| yarnPath: ../.yarn/releases/yarn-4.6.0.cjs |
Comment on lines
+11
to
+12
| async function run({ template }: RunOptions) { | ||
| console.log(template.replace('/', '-')); |
There was a problem hiding this comment.
logic: Template parameter should be validated before use to avoid errors if undefined
Suggested change
| async function run({ template }: RunOptions) { | |
| console.log(template.replace('/', '-')); | |
| async function run({ template }: RunOptions) { | |
| if (!template) throw new Error('Template name is required'); | |
| console.log(template.replace('/', '-')); |
storybook-bot
force-pushed
the
version-patch-from-8.5.3
branch
4 times, most recently
from
e21d57d to
1c4ea25
Compare
storybook-bot
force-pushed
the
version-patch-from-8.5.3
branch
from
1c4ea25 to
87b1981
Compare
…ptional Addon A11y: Make Vitest Axe optional (cherry picked from commit b2d8a3c)
Builder-Vite: Fix allowedHosts handling for custom hosts (cherry picked from commit cfedafb)
|
View your CI Pipeline Execution ↗ for commit e6ab69b.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 56 | 🎉 -3 🎉 |
| Self size | 228 KB | 332 KB | 🚨 +104 KB 🚨 |
| Dependency size | 13.46 MB | 12.71 MB | 🎉 -753 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-docs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 17 | 17 | 0 |
| Self size | 2.20 MB | 2.24 MB | 🚨 +44 KB 🚨 |
| Dependency size | 7.91 MB | 7.91 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 36 | 0 |
| Self size | 12 KB | 12 KB | 0 B |
| Dependency size | 13.87 MB | 13.91 MB | 🚨 +44 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.3to8.5.4.Once this pull request is merged, it will trigger a new release of version
8.5.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x b2d8a3c06b7730abb903465c09045d05475caff3git cherry-pick -m1 -x cfedafbba7ecfd6593dd1c6b2061a5989ce308b1If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.4