Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #3173 #3292

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

derekashauer
Copy link
Contributor

Set membership id and level name to empty string when membership does not exist for the order

All Submissions:

Changes proposed in this Pull Request:

Resolves PHP code notices .

How to test the changes in this Pull Request:

  1. Go to Memberships > Orders
  2. Click "email" for an order where the user currently does not have an active membership and send

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Fix code notice when sending order email to user with no active membership level

Set membership id and level name to empty string when membership does not exist for the order
@dparker1005
Copy link
Member

With PMPro v3.4 breaking templates up into separate classes, this PR needs to be updated to update the variables in the new PMPro_Email_Template_Payment_Receipt class before it can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants