Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved the issue of select element missing scrollbar #1841

Closed
wants to merge 1 commit into from

Conversation

Manoj-M-S
Copy link
Contributor

What does it do?

This PR fixes the issue of select element missing scrollbar.

Why is it needed?

To fix issue 22105: Select element is missing a scrollbar

How to test it?

  1. Go to select component story of the storybook.
  2. Now scrollbar will be visible and items can be scrolled using scrollbar.

Related issue(s)/PR(s)

fixes 22105

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 97c6f8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:37am

@daandegooijer
Copy link

Can we please merge this?

@simotae14
Copy link
Contributor

Hello @Manoj-M-S thanks for the contribution,
you need to add a changeset to specify the modification you are doing
Please follow this guide Click here to learn what changesets are, and how to add one.

@lucasboilly lucasboilly linked an issue Feb 7, 2025 that may be closed by this pull request
2 tasks
@hansemannn
Copy link
Contributor

hansemannn commented Feb 8, 2025

This is getting more and more severe - it causes major internal support inquiries, as people can't properly use the CMS across different features. More details are here.

@daandegooijer
Copy link

Who is in charge of this?

@hansemannn
Copy link
Contributor

@Manoj-M-S I've just added Manoj-M-S#1 that, once merged, will resolve the missing changeset mentioned by @simotae14 :) I hope now everything is ready to be merged!

Then, we'll still need to wait for a new Strapi update, but let's hope that the team see's the urgency similar as the community does!

@simotae14
Copy link
Contributor

@hansemannn thanks for the contribution, instead of creating a PR to add a changeset for this PR you can create a brand new with the modifications implemented in this one and the changeset, after that we can close this PR, thanks

@hansemannn
Copy link
Contributor

hansemannn commented Feb 11, 2025

@simotae14 I wanted to keep this PR as clean as possible, as my new commit would just be merged into the existing head of this PR. If it speeds up the review and merge, I can do that of cause - the commit from @Manoj-M-S will of course remain so his contribution gets honored.

EDIT: Opened #1856 :)

@hanpaine
Copy link
Contributor

Hi @Manoj-M-S thanks for another great contribution - I'm going to close this in favour of #1856 from @hansemannn as with the above conversation 🙏 thanks again folks!

@hanpaine hanpaine closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select element is missing a scrollbar Make the dropdown list items accessible
5 participants