convert const enums to regular enums #1430
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package exports
const enum
s instead of regularenum
s. References to aconst enum
are inlined at compile time, so there is no runtime object associated with the enum. Most modern javascript bundlers compile typescript withisolatedModules: true
which means that type checking doesn't happen across module boundaries, and therefore the enums cannot be inlined.Removing the
const
keyword from these enums means that the compiled javascript build object formodule.ts
will contain runtime objects that can be used to access enum values.