Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWS lambda sink connector private #324

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

RobertIndie
Copy link
Member

No description provided.

@RobertIndie RobertIndie self-assigned this Nov 2, 2023
@RobertIndie RobertIndie requested a review from a team as a code owner November 2, 2023 08:00
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shibd
Copy link
Member

shibd commented Nov 2, 2023

Hi, @RobertIndie We also need to update metadata of source repo.

@shibd
Copy link
Member

shibd commented Nov 2, 2023

CI not pass.

@RobertIndie
Copy link
Member Author

Hi, @RobertIndie We also need to update metadata of source repo.

Okay, I have pushed a PR: https://github.com/streamnative/pulsar-io-aws-lambda/pull/708

@RobertIndie
Copy link
Member Author

Seems that we currently not support for setting a string to the source link: https://github.com/streamnative/pulsar-hub/actions/runs/6740669516/job/18324085609?pr=324#step:4:953

Checking url Private source
Traceback (most recent call last):
  File "/home/runner/work/pulsar-hub/pulsar-hub/ci/projects/pulsar-registry-metadata/validate.py", line 84, in <module>
    validate(args[1])
  File "/home/runner/work/pulsar-hub/pulsar-hub/ci/projects/pulsar-registry-metadata/validate.py", line 70, in validate
    if headers[key] and not is_reachable(value, errors):
  File "/home/runner/work/pulsar-hub/pulsar-hub/ci/projects/pulsar-registry-metadata/validate.py", line 44, in is_reachable
    file = requests.get(url)
  File "/usr/lib/python3/dist-packages/requests/api.py", line 76, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 530, in request
    prep = self.prepare_request(req)
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 458, in prepare_request
    p.prepare(
  File "/usr/lib/python3/dist-packages/requests/models.py", line 316, in prepare
    self.prepare_url(url, params)
  File "/usr/lib/python3/dist-packages/requests/models.py", line 390, in prepare_url
    raise MissingSchema(error)
requests.exceptions.MissingSchema: Invalid URL 'Private source': No schema supplied. Perhaps you meant http://Private source?

@RobertIndie
Copy link
Member Author

I have pushed a PR to fix the CI failures:
https://github.com/streamnative/streamnative-ci/pull/4056

@RobertIndie RobertIndie merged commit 67121a5 into master Nov 3, 2023
@RobertIndie RobertIndie deleted the make-aws-lambda-private branch November 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants