-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc docs #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaks in some browsers (maybe there's local markdown re-render?) the link should be https://docs.streamr.network/guides/become-an-operator/ but it becomes https://docs.streamr.network/guides/how-to-run-streamr-node/become-an-operator probably because the current page is https://docs.streamr.network/guides/how-to-run-streamr-node/ with a slash in the end
I did the NPM path
## Summary Prepended a missing `v` to `100.0.0-pretestnet.3`: `v100.0.0-pretestnet.3`. If node operators paste the string without the `v` prepended e.g. as such: `sudo docker run -p 32200:32200 --name streamr --restart unless-stopped -d -v $(cd ~/.streamrDocker && pwd):/home/streamr/.streamr streamr/broker-node:100.0.0-pretestnet.3` instead of `sudo docker run -p 32200:32200 --name streamr --restart unless-stopped -d -v $(cd ~/.streamrDocker && pwd):/home/streamr/.streamr streamr/broker-node:v100.0.0-pretestnet.3`, updating the Docker container image will fail. ## Limitations and future improvements Perhaps add detailed update instructions to the testnets FAQ :)
## Summary Highlighted important parts related to funds and risk with `<strong>` ## Changes - "**Delegators also share risk**" - "**funds become available as soon as Operators unstake from Sponsorships or after 30 days at the latest**" ## Limitations and future improvements Ideally supplement with a hard-to-miss notice and a link to this doc in the 'Delegate' overlay in the Hub. Co-authored-by: Matthew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1.0 documentation update
Config wizard mainnet description update
Changes
Terminology updates
Client library naming scheme updates
Docker package naming scheme updates
Operator upgrade instructions
Limitations and future improvements
Provide a bullet list or description of known omissions or limitations of the
solution and/or any ideas for future improvement. Leave section ouf if
not applicable.
Checklist before requesting a review
TODO
comments left behind are meant to be left in.