Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change moduleResolution #25

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore: Change moduleResolution #25

merged 1 commit into from
Oct 28, 2024

Conversation

teogeb
Copy link
Collaborator

@teogeb teogeb commented Oct 28, 2024

Removed moduleResolution: node.

That is the deprecated alias to node10 (https://www.typescriptlang.org/tsconfig/#moduleResolution), and we should use modern node16/nodenext instead. By removing the definition we use the inherited value of node16 from @tsconfig/node20/tsconfig.json.

@teogeb teogeb changed the title chorse: Change moduleResolution chore: Change moduleResolution Oct 28, 2024
@teogeb teogeb requested a review from jtakalai October 28, 2024 11:53
Copy link
Contributor

@jtakalai jtakalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't seem to affect the build when I tested

@teogeb teogeb merged commit 185e430 into main Oct 28, 2024
3 checks passed
@teogeb teogeb deleted the chore-moduleResolution branch October 28, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants