[batteryarc] Add support for reading multiple batteries in one batteryarc instance #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiple batteries, each percentage gets added into "charge", and then divided by the number of batteries. Batteries with status "Unknown" don't get counted.
added 2 commits
November 18, 2023 14:50
Add in reset_garbage_collector variable as a hack fix for a memory leak caused when memory is allocated for certain widgets faster than it is consumed (by triggering the garbage collector frequently).
Default to beautiful.font, and use 'Play 9' as a backup.
| if (reset_garbage_collector > 10) then | ||
| collectgarbage() | ||
| reset_garbage_collector = 0 | ||
| end |
There was a problem hiding this comment.
Could you explain how does this work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multiple batteries, each percentage gets added into "charge", and then divided by the number of batteries. Batteries with status "Unknown" don't get counted.
This way you can have a rough overall power indicator (it perhaps could be improved by reading the total capacity of each battery and mathing the actual percentage out of that, but that seems overkill).
I could make it a separate widget, or make it require a flag, if that would be preferable (this could be added to the other pull request about passing an id for which battery for the widget to read, in which case you could pass some other standard number like -1 for every battery).