Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for integration tests #57

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

mimaison
Copy link
Contributor

@mimaison mimaison commented Nov 3, 2024

No description provided.

@mimaison mimaison added this to the 0.2.0 milestone Nov 3, 2024
@mimaison
Copy link
Contributor Author

mimaison commented Nov 4, 2024

I opened the PR to check the integration test worked in the CI. I now need to add a few more tests and do a bit of cleaning, so hold on reviewing for now.

@mimaison
Copy link
Contributor Author

mimaison commented Nov 4, 2024

That's now ready for review. This only exercises broker metrics. I'll raise issues to cover the clients so we add tests for them in follow up PRs.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison mimaison merged commit 1425a3c into strimzi:main Nov 5, 2024
7 checks passed
@mimaison mimaison deleted the issue-56 branch November 5, 2024 14:04
@mimaison mimaison mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants