Allow KafkaRoller talk to controller directly #10016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaselenge
force-pushed
the
add-controller-svc
branch
2 times, most recently
from
c256f5a
to
93053e7
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
3 times, most recently
from
1bf6fab
to
0f6d51f
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
from
0f6d51f
to
eefbd4c
Compare
scholzj
reviewed
Aug 28, 2024
...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
tinaselenge
force-pushed
the
add-controller-svc
branch
2 times, most recently
from
52d9241
to
bb928d6
Compare
tinaselenge
force-pushed
the
add-controller-svc
branch
from
bb928d6
to
6e03523
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I will check the regression test failures. |
|
@scholzj can you please kick off the regression tests again? The failed system tests seem to pass for me when running locally. |
|
@tinaselenge could you please rebase to avoid running |
Update AdminClientProvider to create an admin client for controllers with BOOTSTRAP_CONTROLLERS_CONFIG set. Allow KafkaRoller create admin client against controllers nodes, if they are running 3.9.0 or later. Remove ceShouldBeFatal option as it's never set to true. Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
add-controller-svc
branch
from
6e03523
to
99cc9e2
Compare
|
thanks @Frawless . I rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Closes #9692
Checklist
Please go through this checklist and make sure all applicable tasks have been done