Skip to content

Commit

Permalink
Merge pull request #196 from stringsync/beam
Browse files Browse the repository at this point in the history
Do not render incomplete beams
  • Loading branch information
jaredjj3 authored Jan 4, 2024
2 parents 948a9d3 + 4a09671 commit 6b7b236
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/rendering/beam.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { SpannerMap } from './spannermap';
export type BeamRendering = {
type: 'beam';
vexflow: {
beam: vexflow.Beam;
beam: vexflow.Beam | null;
};
};

Expand Down Expand Up @@ -81,7 +81,7 @@ export class Beam {
/** Renders the beam. */
render(): BeamRendering {
const vfStemmableNotes = this.fragments.map((fragment) => fragment.vexflow.stemmableNote);
const beam = new vexflow.Beam(vfStemmableNotes);
const beam = vfStemmableNotes.length > 1 ? new vexflow.Beam(vfStemmableNotes) : null;

return {
type: 'beam',
Expand Down
2 changes: 1 addition & 1 deletion src/rendering/score.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class Score {

// Draw vexflow.Beam elements.
spannersRendering.beams.forEach((beam) => {
beam.vexflow.beam.setContext(vfContext).draw();
beam.vexflow.beam?.setContext(vfContext).draw();
});

// Draw vexflow.StaveTie elements.
Expand Down

0 comments on commit 6b7b236

Please sign in to comment.