Add correctly failing test

stripe · Feb 14, 2024 · b1c541b · b1c541b
1 parent bf0e961
commit b1c541b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/smokescreen/smokescreen_test.go b/pkg/smokescreen/smokescreen_test.go
@@ -1290,7 +1290,7 @@ func TestCONNECTProxyACLs(t *testing.T) {
 		// fmt.Println(externalProxy.URL)
 		remote := httptest.NewTLSServer(h)
 		fmt.Println(remote.URL)
-		client, err := proxyClientWithConnectHeaders(proxy.URL, http.Header{"X-Upstream-Https-Proxy": []string{"https://google.com"}})
+		client, err := proxyClientWithConnectHeaders(proxy.URL, http.Header{"X-Upstream-Https-Proxy": []string{"https://localhost"}})
 		r.NoError(err)
 
 		req, err := http.NewRequest("GET", remote.URL, nil)
@@ -1300,9 +1300,9 @@ func TestCONNECTProxyACLs(t *testing.T) {
 
 		entry := findCanonicalProxyDecision(logHook.AllEntries())
 		r.NotNil(entry)
-		r.Equal("connect proxy host not allowed in rule", entry.Data["decision_reason"])
-		r.Equal("test-external-connect-proxy-srv", entry.Data["role"])
-		r.Equal(false, entry.Data["allow"])
+		// r.Equal("connect proxy host not allowed in rule", entry.Data["decision_reason"])
+		// r.Equal("test-external-connect-proxy-srv", entry.Data["role"])
+		r.Equal(true, entry.Data["allow"])
 	})
 }
 func findCanonicalProxyDecision(logs []*logrus.Entry) *logrus.Entry {