Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose in the example app. #9851

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Jan 3, 2025

Summary

Just keeping on the latest version.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@jaynewstrom-stripe jaynewstrom-stripe added the accept-risky-change accept-risky-change label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.2 KiB │   7.2 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -8 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -8 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19971 │ 19971 │ 0 (+0 -0) 
   types │  6191 │  6191 │ 0 (+0 -0) 
 classes │  4982 │  4982 │ 0 (+0 -0) 
 methods │ 29771 │ 29771 │ 0 (+0 -0) 
  fields │ 17541 │ 17541 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 28.4 KiB │ -5 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.3 KiB │ -2 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ -8 B │  127 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.6-example branch from 9495a29 to 3da5717 Compare January 3, 2025 16:47
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review January 6, 2025 22:04
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners January 6, 2025 22:04
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) January 6, 2025 22:04
@jaynewstrom-stripe jaynewstrom-stripe merged commit 8b6ad4c into master Jan 6, 2025
15 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/compose-1.7.6-example branch January 6, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants