Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaked images #41

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Leaked images #41

merged 2 commits into from
Nov 20, 2019

Conversation

romanprocopie
Copy link
Contributor

Fixes a problem appearing on Macs with Retina displays.
May be related to issue #32, as I was getting consistent RAM usage increase by a rate 30-40Mb/sec and this fixes it

Copy link
Owner

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. I just have two small suggestions for further improvements.

OSXvnc-server/main.c Outdated Show resolved Hide resolved
OSXvnc-server/main.c Outdated Show resolved Hide resolved
@romanprocopie
Copy link
Contributor Author

romanprocopie commented Nov 18, 2019

Reviewed it, makes perfect sense, I originally followed the path of releasing resourcing in order opposite to how they were created, but obviously there is no dependency, so moved those lines up

@romanprocopie romanprocopie requested a review from stweil November 18, 2019 11:50
@romanprocopie
Copy link
Contributor Author

Anything else I need to do here, or perhaps I did not press a button ? no worries if it is just lack of time

Copy link
Owner

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again.

@stweil stweil merged commit e54c7e9 into stweil:master Nov 20, 2019
stweil pushed a commit that referenced this pull request Nov 20, 2019
@stweil stweil added the bug label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants