Migration frax subgraph #81
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Generic Password | dbba04b | Zksync/zksync-starter/docker-compose.yml | View secret | |
| - | Generic Password | 0e59212 | Altlayer/altlayer-op-demo-starter/docker-compose.yml | View secret | |
| - | Generic Password | 0e59212 | Artela/artela-testnet-starter/docker-compose.yml | View secret | |
| - | Generic Password | 0e59212 | Aurora/aurora-starter/docker-compose.yml | View secret | |
| - | Generic Password | dbba04b | Immutable/immutable-testnet-starter/docker-compose.yml | View secret | |
| - | Generic Password | 0e59212 | Arbitrum/arbitrum-one-winr/docker-compose.yml | View secret | |
| - | Generic Password | 9e984ed | Ethereum/ethereum-frax/docker-compose.yml | View secret | |
| - | Generic Password | dbba04b | Meter/meter-starter/docker-compose.yml | View secret | |
| - | Generic Password | dbba04b | Scroll/scroll-sepolia-starter/docker-compose.yml | View secret | |
| - | Generic Password | 0e59212 | Astar/astar-zkevm-testnet-starter/docker-compose.yml | View secret | |
| - | Generic Password | 47126cd | Meteor/meteor-starter/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
gitguardian & Git builder - set wrong status. |
|
@bgodlin can you please review this? |
There was a problem hiding this comment.
Apart from the comments scattered within the specified files:
- Is the
testsfolder actually utilised? If not, kindly remove it along with its contents. - It appears that another starter named Meteor has been added as part of this pull request, which is unrelated to the context of this PR.
There was a problem hiding this comment.
This file isn't necessary in the public repository
There was a problem hiding this comment.
This file isn't necessary in the public repository
There was a problem hiding this comment.
Please consider relocating this to the designated section in README.md (refer to other examples for guidance)
There was a problem hiding this comment.
Is there a specific guide available on how to utilise this file? If it's intended to remain, then a guide detailing the configuration of those parameters should be provided. Alternatively, you can directly copy the values provided here and manually fill in the placeholders - once completed, the file becomes unnecessary.
| # - --debug=* | ||
| # - --log-level=debug | ||
| - --db-schema=app | ||
| - --workers=1 |
There was a problem hiding this comment.
| - --workers=1 | |
| - --workers=4 |
| // TODO: hexString -> utf8 string | ||
| // throw new Error('Not implemented') | ||
| } else { | ||
| throw new Error(`Unknown symbol. Token#108`) |
There was a problem hiding this comment.
In these and subsequent cases, will the project halt with an error? Is there a potential for handling this differently?
| import { | ||
| BIG_INT_ZERO, | ||
| MINIMUM_USD_THRESHOLD_NEW_PAIRS, | ||
| WHITELIST | ||
| } from "../packages/constants/index.template"; |
There was a problem hiding this comment.
WHITELIST is a constant requiring placeholders to be filled with values from template files. Please consult the comment in file Ethereum/ethereum-frax/config/mainnet.json to resolve this matter.
|
|
||
|
|
There was a problem hiding this comment.
A dynamic source creation is absent. Please refer to the comment in Ethereum/ethereum-frax/project.ts.
Line in the source:
PairTemplate.create(event.params.pair)
There was a problem hiding this comment.
Please relate to the comment in Ethereum/ethereum-frax/config/mainnet.json
| import { | ||
| MINIMUM_LIQUIDITY_THRESHOLD_ETH, | ||
| FRAX_FXS_PAIR, | ||
| FRAXSWAP_FRAX_WETH_PAIR, | ||
| FRAX, | ||
| NATIVE | ||
| } from "./packages/constants/index.template"; |
There was a problem hiding this comment.
Some constants are requiring placeholders to be filled with values from template files. Please consult the comment in file Ethereum/ethereum-frax/config/mainnet.json to resolve this matter.
♨ Migrated FraxSwap subgraph from Thegraph to Subquery.
✍ https://github.com/FraxFinance/fraxswap-subgraph
✔️ Chain id: 1