Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polygon destination #296

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add polygon destination #296

merged 3 commits into from
Dec 12, 2023

Conversation

ianhe8x
Copy link
Contributor

@ianhe8x ianhe8x commented Dec 12, 2023

Changes

  • InflationController
    • lastInflationTimestamp is not set on initialize() anymore. Now the first call of mintInflatedTokens() will emit InflationStart() and set lastInflationTimestamp; Inflation will start minted after the first call (exclusive).
    • use ERC165CheckerUpgradeable instead of isContract check
  • PolygonDestination
    • implement InflationDestination and ERC165
    • can set xcRecipient and will call rootchainmanager to deposit to polygon
    • admin can withdraw if any token mistakenly locked.

@ianhe8x ianhe8x requested a review from mzxyz December 12, 2023 03:05
@gitguardian GitGuardian
Copy link

gitguardian bot commented Dec 12, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ianhe8x ianhe8x changed the base branch from kepler-network to develop December 12, 2023 03:09
@ianhe8x ianhe8x changed the title Test polygon dest Add polygon destination Dec 12, 2023
mzxyz
mzxyz reviewed Dec 12, 2023
View reviewed changes
scripts/deployContracts.ts
// deploy MockRootChainManager
rootChainManager = await new RootChainManager__factory(wallet).deploy();
}
// tx = await inflationController.setInflationDestination(polygonDestination.address);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to uncomment this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will break some inflation tests which expects a normal wallet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the mainnet, we can set that after the contract creation.

@ianhe8x ianhe8x merged commit 8de6dfc into develop Dec 12, 2023
2 checks passed
@ianhe8x ianhe8x deleted the test-polygon-dest branch December 12, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzxyz mzxyz mzxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianhe8x @mzxyz