Refactor `store.service` Add support for relations, enums, subscription on Schema Migration #2251

bz888 · 2024-02-12T03:29:14Z

Description

Fixes and Updates

Support Enums
Support Subscription
Support Relations
Cyclic schema
Historical (complex schema, multiple relationals)
Non-historical (complex schema, multiple relationals)
QueryGenerators

Refactor store.serivce to use generate queries instead of sequelize.sync()

Fixes:
#2249
#2241

Documentation:
subquery/documentation#474

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I have tested locally
I have performed a self review of my changes
Updated any relevant documentation
Linked to any relevant issues
I have added tests relevant to my changes
Any dependent changes have been merged and published in downstream modules
My code is up to date with the base branch
I have updated relevant changelogs. We suggest using chan

…e.sync

…eIndex with historical, add relations support, update util functions

…s, add test for subscriptions

stwiname

One concern i have is that this will break local development, what happens with schema changes when not dealing with projects? The behaviour should be the same as before.

packages/node-core/CHANGELOG.md

packages/node-core/src/configure/migration-service/SchemaMigration.service.ts

packages/node-core/src/configure/migration-service/migration.ts

…tart on syncSchema

packages/node-core/src/configure/migration-service/SchemaMigration.service.ts

packages/node-core/src/configure/migration-service/migration-helpers.ts

packages/node-core/src/configure/migration-service/migration.ts

packages/node-core/src/configure/SchemaMigration.service.spec.ts

packages/node-core/src/configure/migration-service/migration-helpers.ts

packages/node-core/src/configure/migration-service/migration.ts

stwiname · 2024-02-13T21:44:26Z

There still seems to be quite a few TODOs scattered about

…view

stwiname

There still seem to be a couple of TODOs in places

packages/node-core/src/db/index.ts

packages/node-core/src/indexer/store.service.ts

packages/node-core/src/db/migration-service/migration.ts

stwiname · 2024-02-15T00:45:11Z

packages/node-core/src/utils/graphql.ts

    : field.isArray
    ? getTypeByScalarName('Json')?.sequelizeType
    : getTypeByScalarName(field.type)?.sequelizeType;

-  if (type === undefined) {
+  if (type === undefined || type === 'undefined') {


Whats going on here? Why would it be 'undefined'?

bz888 added 16 commits February 8, 2024 17:31

update schema migration with raw query execution, instead of sequeliz…

f39f985

…e.sync

fix tests

629b57c

update changelog

6fdcc36

tidy up test for historical db sync, update statement generators

ba27ace

update topo logic, add tests, add sync logic with cyclic support

cc23277

revert bad rebase on migeration class

23658a1

revert bad rebase on migeration class

225d464

refacotr toposort, updated sync-helper tests

cdeeec9

update schema migration with raw query execution, instead of sequeliz…

ab0785f

…e.sync

add relational support on schema migration, fix table comments

2b1e969

fix tableComments, refactor createTable and createModel, update creat…

76d1946

…eIndex with historical, add relations support, update util functions

add drop relations, add check for fkey on creation relations, add tests

c3cd09b

refactor drop table and column with relational foreign keys, fix test…

8c20565

…s, add test for subscriptions

update syncSchema logic with migration.run()

d63efae

added test for enum creation, and enum support on drop and creation

4c5fee5

clean up comments and logs

7dbb468

bz888 mentioned this pull request Feb 12, 2024

Update table creation on schema migration #2244

Closed

12 tasks

stwiname reviewed Feb 12, 2024

View reviewed changes

bz888 added 2 commits February 13, 2024 15:24

update based on review, add idempotency to db queries

d0b6c36

check matching ddl, fixed relation comments, benchmarked init and res…

3a8c55a

…tart on syncSchema