Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node version to lts #2655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update node version to lts #2655

wants to merge 1 commit into from

Conversation

stwiname
Copy link
Collaborator

Description

Update to LTS and continue to use LTS rather than manually updating to LTS. Work towards #2304

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions GitHub Actions
Copy link

Coverage report for .

St.❔
 Category Percentage Covered / Total
🟡 Statements
67.2% (-2.91% 🔻)
 20590/30639
🟡 Branches
78.28% (-0.01% 🔻)
 2750/3513
🟡 Functions
70.36% (+7.86% 🔼)
 1144/1626
🟡 Lines
67.2% (-2.91% 🔻)
 20590/30639
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / migrate.ts
 85.34% 9.09% 100% 85.34%
🟢
... / migrate-abis.controller.ts
 95% 87.5% 100% 95%
🟢
... / constants.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / ethereum.ts
 82.28% 83.33% 100% 82.28%
🟢
... / migrate-manifest.controller.ts
 88% 73.33% 88.89% 88%
🟢
... / migrate-mapping.controller.ts
 100% 100% 100% 100%
🟢
... / migrate-controller.ts
 92.41% 84.62% 100% 92.41%
🟢
... / migrate.fixtures.ts
 100% 100% 100% 100%
🟢
... / migrate-schema.controller.ts
 97.23% 79.22% 100% 97.23%
🔴
... / types.ts
 0% 0% 0% 0%
🟢
... / createProject.fixtures.ts
 94.92% 77.78% 100% 94.92%
🟢
... / config.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🔴
... / moduleLoader.ts
 56% 40% 100% 56%
🟢
... / types.ts
 100% 100% 100% 100%
🔴
... / utils.ts
 0% 0% 0% 0%
🟢
... / networkFamily.ts
 92.59% 88.89% 100% 92.59%
🟡
... / IPFSHTTPClientLite.ts
 76.47% 80% 88.89% 76.47%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / utils.ts
 92% 66.67% 100% 92%
🟡
... / admin.controller.ts
 75.56% 96% 78.57% 75.56%
🟡
... / blockRange.ts
 70.37% 100% 80% 70.37%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / SubqueryProject.ts
 86.21% 83.33% 71.43% 86.21%
🟢
... / core.module.ts
 100% 100% 100% 100%
🟢
... / dictionary.fixtures.ts
 100% 100% 100% 100%
🟡
... / monitor.service.ts
 69.61% 85.88% 94.12% 69.61%
🔴
... / sandbox.service.ts
 33.33% 50% 25% 33.33%
🟡
... / baseCache.service.ts
 67.57% 92.31% 66.67% 67.57%
🟡
... / baseStoreModel.service.ts
 64.41% 83.33% 83.33% 64.41%
🟢
... / cacheable.ts
 89.29% 75% 100% 89.29%
🟡
... / csvStore.ts
 75% 73.68% 85.71% 75%
🟡
... / exporter.ts
 71.67% 71.43% 71.43% 71.67%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟡
... / cacheMetadata.ts
 67.4% 75% 86.67% 67.4%
🟢
... / index.ts
 100% 100% 100% 100%
🔴
... / metadata.ts
 54.22% 71.43% 55.56% 54.22%
🟢
... / utils.ts
 100% 100% 100% 100%
🟢
... / cacheModel.ts
 87.05% 82.28% 90% 87.05%
🟢
... / index.ts
 100% 100% 100% 100%
🟡
... / model.ts
 75.31% 70.83% 90.91% 75.31%
🟢
... / utils.ts
 100% 100% 100% 100%
🟡
... / cachePoi.ts
 77.89% 89.47% 85.71% 77.89%
🟢
... / index.ts
 100% 100% 100% 100%
🔴
... / poi.ts
 41.96% 71.43% 44.44% 41.96%
🟢
... / setValueModel.ts
 80.77% 72.73% 85.71% 80.77%
🟡
... / storeCache.service.ts
 65.7% 67.86% 76.92% 65.7%
🟡
... / storeModel.service.ts
 61.54% 50% 71.43% 61.54%
🟢
... / types.ts
 100% 100% 100% 100%
🟢
... / utils.ts
 93.33% 66.67% 100% 93.33%
🟢
... / worker.core.module.ts
 100% 100% 0% 100%
🔴
... / worker.monitor.service.ts
 39.53% 100% 0% 39.53%
🔴
... / meta.controller.ts
 53.33% 100% 0% 53.33%
🟡
... / meta.module.ts
 60% 100% 0% 60%
🟡
... / process.ts
 61.29% 100% 40% 61.29%
🔴
... / foreceClean.init.ts
 47.62% 100% 0% 47.62%
🔴
... / reindex.init.ts
 33.33% 100% 0% 33.33%
🟡
... / autoQueue.ts
 65.85% 86.49% 73.33% 65.85%
🟢
... / index.ts
 100% 100% 100% 100%
🔴
... / queue.ts
 47.22% 80% 66.67% 47.22%
🟡
... / rampQueue.ts
 78.72% 91.3% 87.5% 78.72%
🟢
... / string.ts
 100% 95.45% 100% 100%
🔴
... / datasourceProcessors.ts
 0% 0% 0% 0%
🔴
... / index.ts
 0% 0% 0% 0%
🔴
... / types.ts
 0% 0% 0% 0%
🔴
... / networking.ts
 31.58% 100% 0% 31.58%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / delete.ts
48.72% (-5.57% 🔻)
 100% 0%
48.72% (-5.57% 🔻)
🔴
... / promote.ts
44.19% (-4.53% 🔻)
 100% 0%
44.19% (-4.53% 🔻)
🟡
... / add.ts
61.29% (-0.78% 🔻)
 100% 0%
61.29% (-0.78% 🔻)
🟢
... / publish.ts
83.72% (-5.61% 🔻)
 57.14% 100%
83.72% (-5.61% 🔻)
🔴
... / add-chain-controller.ts
39.85% (-0.23% 🔻)
 66.67% 30%
39.85% (-0.23% 🔻)
🟢
... / build-controller.ts
90.44% (-0.86% 🔻)
71.43% (+14.29% 🔼)
 100%
90.44% (-0.86% 🔻)
🟢
... / codegen-controller.ts
88.77% (-0.62% 🔻)
82.67% (+7.09% 🔼)
 100%
88.77% (-0.62% 🔻)
🟡
... / deploy-controller.ts
64.94% (+27.48% 🔼)
72.73% (-5.05% 🔻)
64.29% (+39.29% 🔼)
64.94% (+27.48% 🔼)
🟢
... / generate-controller.ts
97.75% (+0.1% 🔼)
93.24% (-0.79% 🔻)
 100%
97.75% (+0.1% 🔼)
🟡
... / init-controller.ts
76.21% (+5.73% 🔼)
63.64% (-4.36% 🔻)
61.11% (+7.78% 🔼)
76.21% (+5.73% 🔼)
🟢
... / project-controller.ts
83.13% (-14.13% 🔻)
42.86% (-17.14% 🔻)
75% (-25% 🔻)
83.13% (-14.13% 🔻)
🟢
... / publish-controller.ts
82.63% (+2.38% 🔼)
70.27% (-0.84% 🔻)
 100%
82.63% (+2.38% 🔼)
🟡
... / load.ts
79.41% (-8.82% 🔻)
66.67% (-19.05% 🔻)
 100%
79.41% (-8.82% 🔻)
🔴
... / models.ts
55.56% (-43.89% 🔻)
94.12% (+1.81% 🔼)
30.77% (-69.23% 🔻)
55.56% (-43.89% 🔻)
🟢
... / ProjectManifestVersioned.ts
82.19% (-2.74% 🔻)
88.89% (-11.11% 🔻)
61.54% (+3.21% 🔼)
82.19% (-2.74% 🔻)
🟢
... / model.ts
94.29% (-3.43% 🔻)
 100%
73.33% (+1.9% 🔼)
94.29% (-3.43% 🔻)
🔴
... / models.ts
52.94% (-47.06% 🔻)
 100%
0% (-100% 🔻)
52.94% (-47.06% 🔻)
🟡
... / load.ts
64.29% (+5.1% 🔼)
38.89% (-16.67% 🔻)
83.33% (+16.67% 🔼)
64.29% (+5.1% 🔼)
🟡
... / github-reader.ts
67.24% (-22.04% 🔻)
85.71% (+10.71% 🔼)
71.43% (-11.9% 🔻)
67.24% (-22.04% 🔻)
🟡
... / ipfs-reader.ts
63.49% (-22.22% 🔻)
72.73% (+9.09% 🔼)
71.43% (-11.9% 🔻)
63.49% (-22.22% 🔻)
🟡
... / local-reader.ts
70% (-16.05% 🔻)
100% (+37.5% 🔼)
83.33% (-16.67% 🔻)
70% (-16.05% 🔻)
🟢
... / reader.ts
81.58% (-7.89% 🔻)
57.14% (-17.86% 🔻)
 100%
81.58% (-7.89% 🔻)
🔴
... / base.ts
47.66% (-50.34% 🔻)
87.5% (-12.5% 🔻)
40% (-40% 🔻)
47.66% (-50.34% 🔻)
🔴
... / models.ts
31.74% (-68.26% 🔻)
 100%
0% (-100% 🔻)
31.74% (-68.26% 🔻)
🟢
... / NodeConfig.ts
88.92% (+0.31% 🔼)
80% (+0.37% 🔼)
84.91% (-1.14% 🔻)
88.92% (+0.31% 🔼)
🟡
... / ProjectUpgrade.service.ts
78.94% (-8.14% 🔻)
78.82% (-12.53% 🔻)
92.31% (+1% 🔼)
78.94% (-8.14% 🔻)
🟡
... / configure.module.ts
76.89% (-7.68% 🔻)
54.76% (-9.24% 🔻)
 100%
76.89% (-7.68% 🔻)
🟢
... / db.module.ts
89.63% (+1.35% 🔼)
62.5% (-20.83% 🔻)
 80%
89.63% (+1.35% 🔼)
🟢
... / SchemaMigration.service.ts
84.57% (-2.99% 🔻)
82.35% (+1.1% 🔼)
83.33% (-16.67% 🔻)
84.57% (-2.99% 🔻)
🟡
... / migration-helpers.ts
75.28% (-0.74% 🔻)
88.24% (+7.64% 🔼)
 90.91%
75.28% (-0.74% 🔻)
🟡
... / migration.ts
73.39% (-8.89% 🔻)
83.33% (+3.6% 🔼)
85% (-5.48% 🔻)
73.39% (-8.89% 🔻)
🟡
... / StoreOperations.ts
67.06% (-25.25% 🔻)
60% (-25% 🔻)
87.5% (-12.5% 🔻)
67.06% (-25.25% 🔻)
🔴
... / benchmark.service.ts
44.76% (-10.49% 🔻)
 66.67%
36.36% (-3.64% 🔻)
44.76% (-10.49% 🔻)
🔴
... / base-block-dispatcher.ts
17.94% (-29.41% 🔻)
 100%
4.55% (-5.45% 🔻)
17.94% (-29.41% 🔻)
🔴
... / block-dispatcher.ts
30.66% (-10.33% 🔻)
 66.67% 28.57%
30.66% (-10.33% 🔻)
🔴
... / worker-block-dispatcher.ts
15.96% (-34.25% 🔻)
 100%
0% (-27.27% 🔻)
15.96% (-34.25% 🔻)
🔴
... / coreDictionary.ts
46.67% (-53.33% 🔻)
87.5% (-6.94% 🔻)
77.78% (-22.22% 🔻)
46.67% (-53.33% 🔻)
🟡
... / dictionary.service.ts
68.97% (-16.18% 🔻)
83.78% (-1.93% 🔻)
83.33% (-7.58% 🔻)
68.97% (-16.18% 🔻)
🟢
... / utils.ts
92.59% (-3.7% 🔻)
69.23% (-24.89% 🔻)
 100%
92.59% (-3.7% 🔻)
🟡
... / dictionaryV1.ts
77.55% (-15.68% 🔻)
76.6% (-1.67% 🔻)
91.67% (-8.33% 🔻)
77.55% (-15.68% 🔻)
🟢
... / dictionaryV2.ts
81.05% (-0.62% 🔻)
71.88% (+6.66% 🔼)
88.89% (-11.11% 🔻)
81.05% (-0.62% 🔻)
🔴
... / ds-processor.service.ts
38.57% (-23.53% 🔻)
 75%
58.33% (-29.17% 🔻)
38.57% (-23.53% 🔻)
🟡
... / dynamic-ds.service.ts
60.94% (-29.26% 🔻)
65% (-1.67% 🔻)
80% (-5.71% 🔻)
60.94% (-29.26% 🔻)
🟢
... / inMemoryCache.service.ts
86.21% (-13.79% 🔻)
 100%
75% (-25% 🔻)
86.21% (-13.79% 🔻)
🔴
... / indexer.manager.ts
16.9% (-16.31% 🔻)
 100%
10% (-2.5% 🔻)
16.9% (-16.31% 🔻)
🟡
... / PoiBlock.ts
74.19% (-24.19% 🔻)
57.89% (-38.66% 🔻)
75% (-25% 🔻)
74.19% (-24.19% 🔻)
🔴
... / poi.service.ts
55.7% (+31.78% 🔼)
57.69% (-42.31% 🔻)
80% (+51.43% 🔼)
55.7% (+31.78% 🔼)
🔴
... / poiSync.service.ts
55.88% (-31% 🔻)
77.61% (+1.05% 🔼)
88.89% (-3.42% 🔻)
55.88% (-31% 🔻)
🟡
... / project.service.ts
73.75% (-6.25% 🔻)
76.06% (+5.88% 🔼)
85.19% (+1.19% 🔼)
73.75% (-6.25% 🔻)
🔴
... / sandbox.ts
59.55% (-8.43% 🔻)
53.33% (-3.81% 🔻)
57.14% (-4.4% 🔻)
59.55% (-8.43% 🔻)
🔴
... / store.service.ts
59.4% (-6.64% 🔻)
73.33% (+4.91% 🔼)
80.65% (+23.5% 🔼)
59.4% (-6.64% 🔻)
🔴
... / entity.ts
53.57% (-7.97% 🔻)
 100%
50% (+50% 🔼)
53.57% (-7.97% 🔻)
🔴
... / store.ts
30.59% (-1.62% 🔻)
62.5% (-37.5% 🔻)
33.33% (+33.33% 🔼)
30.59% (-1.62% 🔻)
🟢
... / test.runner.ts
95.06% (-4.27% 🔻)
77.78% (+4.44% 🔼)
75% (-25% 🔻)
95.06% (-4.27% 🔻)
🔴
... / testing.service.ts
11.54% (-17.03% 🔻)
 100% 0%
11.54% (-17.03% 🔻)
🔴
... / unfinalizedBlocks.service.ts
56.52% (-27.47% 🔻)
75% (-21.72% 🔻)
92% (+0.33% 🔼)
56.52% (-27.47% 🔻)
🟡
... / worker.builder.ts
61.97% (-17.22% 🔻)
 65.38% 80%
61.97% (-17.22% 🔻)
🔴
... / worker.cache.service.ts
48.78% (-9.76% 🔻)
 100% 0%
48.78% (-9.76% 🔻)
🔴
... / worker.connectionPoolState.manager.ts
38.21% (-22.76% 🔻)
 100% 0%
38.21% (-22.76% 🔻)
🔴
... / worker.dynamic-ds.service.ts
44.44% (-17.78% 🔻)
 100% 0%
44.44% (-17.78% 🔻)
🔴
... / worker.service.ts
21.24% (-23.4% 🔻)
 100% 0%
21.24% (-23.4% 🔻)
🔴
... / worker.ts
41.18% (-1.28% 🔻)
 100% 0%
41.18% (-1.28% 🔻)
🔴
... / worker.unfinalizedBlocks.service.ts
26.79% (-73.21% 🔻)
 100%
0% (-100% 🔻)
26.79% (-73.21% 🔻)
🔴
... / logger.ts
49.3% (-15.18% 🔻)
 33.33%
40% (+20% 🔼)
49.3% (-15.18% 🔻)
🔴
... / event.listener.ts
16.16% (-64.65% 🔻)
 100%
0% (-25% 🔻)
16.16% (-64.65% 🔻)
🔴
... / health.controller.ts
37.93% (-17.24% 🔻)
 100%
0% (-50% 🔻)
37.93% (-17.24% 🔻)
🔴
... / health.service.ts
21.05% (-36.48% 🔻)
 100%
0% (-20% 🔻)
21.05% (-36.48% 🔻)
🔴
... / meta.service.ts
35.19% (-34.34% 🔻)
100% (+20% 🔼)
0% (-40% 🔻)
35.19% (-34.34% 🔻)
🔴
... / ready.controller.ts
34.78% (-21.74% 🔻)
 100%
0% (-50% 🔻)
34.78% (-21.74% 🔻)
🔴
... / ready.service.ts
37.5% (-54.17% 🔻)
 100%
0% (-66.67% 🔻)
37.5% (-54.17% 🔻)
🔴
... / forceClean.service.ts
21.05% (-5.26% 🔻)
 100% 0%
21.05% (-5.26% 🔻)
🔴
... / reindex.service.ts
18.62% (-14.71% 🔻)
 100% 0%
18.62% (-14.71% 🔻)
🟡
... / blocks.ts
71.21% (-28.79% 🔻)
91.67% (+2.78% 🔼)
75% (-25% 🔻)
71.21% (-28.79% 🔻)
🟡
... / project.ts
71.88% (-1.49% 🔻)
75% (+0.42% 🔼)
 77.78%
71.88% (-1.49% 🔻)
🟢
... / promise.ts
88.14% (-3.63% 🔻)
100% (+13.64% 🔼)
71.43% (-14.29% 🔻)
88.14% (-3.63% 🔻)
🟢
... / reindex.ts
82.05% (+48.01% 🔼)
14.29% (-85.71% 🔻)
100% (+100% 🔼)
82.05% (+48.01% 🔼)
🔴
... / yargs.ts
44.18% (-1.3% 🔻)
 100% 14.29%
44.18% (-1.3% 🔻)
🟡
... / apiPromise.connection.ts
78.13% (+9.05% 🔼)
54.55% (-25.45% 🔻)
66.67% (+23.81% 🔼)
78.13% (+9.05% 🔼)
🟡
... / block-dispatcher.service.ts
62.83% (-6.04% 🔻)
 100%
28.57% (+3.57% 🔼)
62.83% (-6.04% 🔻)
🔴
... / worker-block-dispatcher.service.ts
27.52% (-9.44% 🔻)
 100% 0%
27.52% (-9.44% 🔻)
🟢
... / substrateDictionary.service.ts
98.11% (+7.55% 🔼)
66.67% (-6.06% 🔻)
100% (+20% 🔼)
98.11% (+7.55% 🔼)
🟢
... / substrateDictionaryV1.ts
85.19% (-0.3% 🔻)
78.72% (+8.96% 🔼)
84.62% (+1.28% 🔼)
85.19% (-0.3% 🔻)
🟡
... / substrateDictionaryV2.ts
73.03% (-2.48% 🔻)
 75% 33.33%
73.03% (-2.48% 🔻)
🟢
... / fetch.module.ts
89.6% (-2.27% 🔻)
50% (-25% 🔻)
 100%
89.6% (-2.27% 🔻)
🔴
... / indexer.manager.ts
50% (-7.55% 🔻)
 100%
20% (+10.91% 🔼)
50% (-7.55% 🔻)
🟡
... / base-runtime.service.ts
72.17% (-0.15% 🔻)
76.92% (+1.92% 🔼)
77.78% (+2.78% 🔼)
72.17% (-0.15% 🔻)
🟢
... / runtimeService.ts
94.52% (+2.31% 🔼)
81.82% (-7.07% 🔻)
100% (+20% 🔼)
94.52% (+2.31% 🔼)
🟡
... / types.ts
70.45% (-14.84% 🔻)
 100% 0%
70.45% (-14.84% 🔻)
🟢
... / unfinalizedBlocks.service.ts
85.45% (-0.82% 🔻)
 100%
60% (+10% 🔼)
85.45% (-0.82% 🔻)
🔴
... / http.ts
50.97% (-28.96% 🔻)
50% (+10% 🔼)
42.86% (+12.09% 🔼)
50.97% (-28.96% 🔻)
🟢
... / project.ts
88.73% (-0.16% 🔻)
 68.18% 87.5%
88.73% (-0.16% 🔻)
🟢
... / buffer.ts
95.12% (-4.88% 🔻)
95.83% (-4.17% 🔻)
90.48% (+6.27% 🔼)
95.12% (-4.88% 🔻)
🟡
... / logger.ts
70.35% (+0.75% 🔼)
51.85% (-3.15% 🔻)
78.57% (+3.57% 🔼)
70.35% (+0.75% 🔼)

Test suite run success

600 tests passing in 107 suites.

Report generated by 🧪jest coverage report action from 9f6acf3

@stwiname
Copy link
Collaborator Author

This seems to be producing some deprecation warnings when running

(node:60594) [DEP0056] DeprecationWarning: The `util.isString` API is deprecated.  Please use `typeof arg === "string"` instead.
    at Interval (/Users/scotttwiname/Projects/subql-main/node_modules/@nestjs/schedule/dist/decorators/interval.decorator.js:12:57)
    at Object.<anonymous> (/Users/scotttwiname/Projects/subql-main/packages/node-core/src/indexer/connectionPoolState.manager.ts:87:12)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Module.m._compile (/Users/scotttwiname/Projects/subql-main/node_modules/ts-node/src/index.ts:1618:23)
    at node:internal/modules/cjs/loader:1699:10
    at Object.require.extensions.<computed> [as .ts] (/Users/scotttwiname/Projects/subql-main/node_modules/ts-node/src/index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
(node:60594) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
    at loadBuiltinModule (node:internal/modules/helpers:110:7)
    at Function._load (node:internal/modules/cjs/loader:1095:17)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1335:12)
    at require (node:internal/modules/helpers:136:16)
    at Object.<anonymous> (/Users/scotttwiname/Projects/subql-main/node_modules/whatwg-url/lib/url-state-machine.js:2:18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stwiname