Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement real relation type [WIP] #78

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ingomueller-net
Copy link
Collaborator

No description provided.

@ingomueller-net ingomueller-net force-pushed the relation-type branch 2 times, most recently from 8953465 to d5e458e Compare February 10, 2025 08:41
@ingomueller-net
Copy link
Collaborator Author

I am still unsure about what assembly format is best. We have the following possibilities:

%0 = named_table @t1 as ["a"] : <si32>  // no typename by default
%0 = named_table @t1 as ["a"] : !substrait.relation<si32>  // always fully qualified name
%0 = named_table @t1 as ["a"] : relation<si32>  // short pseudo-typename

If no type name is the default, we have to rely on the reader's knowledge that the ops always return relations. If we always print the fully qualified name, some ops get quite verbose (set ops can have several operands plus the result, which would all repeat that it's a relation). The short pseudo-typename would really be a keyword, which (1) would need to be defined for each op and (2) wouldn't color as a type in IDEs. Any opinions, @jpienaar or @dshaaban01?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant