Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release automation and commit message conventions #38

Closed
mbrobbel opened this issue Dec 9, 2022 · 3 comments
Closed

Release automation and commit message conventions #38

mbrobbel opened this issue Dec 9, 2022 · 3 comments

Comments

@mbrobbel
Copy link
Member

mbrobbel commented Dec 9, 2022

Following substrait and substrait-java (and with the plan for the validator in substrait-io/substrait-validator#4) I would like to propose to setup release automation for this repository using semantic-release and conventional commits.

@jacques-n @andygrove you are listed as the crate owners on crates.io, how do you feel about this? Would you be willing to provide an API token for crates.io (add this as secret in this repo) to publish those releases?

I can contribute the PRs to enable these changes.
@andygrove
Copy link
Contributor

+1 for release automation following the approach uses in the other repos here.

Would you be willing to provide an API token for crates.io (add this as secret in this repo) to publish those releases?

Sure, if you can give me instructions on how to add as a secret here.

This was referenced Dec 16, 2022
Closed
Closed
@mbrobbel
Copy link
Member Author

@andygrove can you please add a crates.io token (with permissions to publish the substrait crate) secret named CRATES_IO_TOKEN? The steps to add a secret are listed here.

@andygrove
Copy link
Contributor

@andygrove can you please add a crates.io token (with permissions to publish the substrait crate) secret named CRATES_IO_TOKEN? The steps to add a secret are listed here.

I don't have the necessary permissions to do this. Maybe @jacques-n can help with this.

bors bot pushed a commit that referenced this issue Jan 2, 2023
@mbrobbel
feat!: follow conventional commits and setup automated releases (#48)
5c46cca 
Closes #38 and #43.

With bors configured in this repository the flow is a bit different, but I think this should be a good setup to allow automating releases. Instead of requiring commit messages to follow the Conventional Commits specification, we just require the PR title to follow it, since that is what ends up being the commit message of the squash merge commit.

Overlaps with #47 so closing that one.
bors bot pushed a commit that referenced this issue Jan 13, 2023
@mbrobbel
feat!: follow conventional commits and setup automated releases (#48)
34d76d9 
Closes #38 and #43.

With bors configured in this repository the flow is a bit different, but I think this should be a good setup to allow automating releases. Instead of requiring commit messages to follow the Conventional Commits specification, we just require the PR title to follow it, since that is what ends up being the commit message of the squash merge commit.

Overlaps with #47 so closing that one.
@bors bors bot closed this as completed in f8f50d3 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andygrove @mbrobbel