ollama-pvc e2e test #416
Open
ollama-pvc e2e test #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstogner
requested changes
Feb 24, 2025
| @@ -38,3 +38,5 @@ for i in {1..10}; do | |||
| -H "Content-Type: application/json" \ | |||
| -d '{"model": "opt-125m-cpu", "prompt": "Who was the first president of the United States?", "max_tokens": 40}' | |||
| done | |||
|
|
|||
| helm uninstall kubeai-models # cleans up above model helm chart on success | |||
There was a problem hiding this comment.
This is probably an oversight from before, we should be doing a kubectl delete models --all in the wrapper after each test case.
There was a problem hiding this comment.
We will want to remove the helm installation, not just the models, maybe in the wrapper?
There was a problem hiding this comment.
That should happen (I wonder if it is not removing the CRDs, or not executing):
cleanup() {
echo "Running test framework cleanup..."
if [ $skaffold_pid != 9999999999999999 ]; then
kill $skaffold_pid
wait $skaffold_pid
fi
skaffold delete -f $REPO_DIR/skaffold.yaml
}
nstogner
reviewed
Mar 2, 2025
|
|
||
| // check to see if the pvc model has a query string, set model to query string, path to host | ||
|
|
||
| if scheme == "pvc" { |
There was a problem hiding this comment.
I would remove the scheme == "pvc" check. I dont think it is needed, and it might cause confusion as to why the model param is not getting parsed in the future if we support scheme == "pv" or something else.
| return modelURL{}, fmt.Errorf("invalid model URL: %s", urlStr) | ||
| } | ||
| scheme, ref := matches[1], matches[2] | ||
| name, path, _ := strings.Cut(ref, "/") | ||
| modelParam := "" |
There was a problem hiding this comment.
var modelParam string is more idiomatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for ollama PVC, specifically an e2e test for #392 to verify that it works.