Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve op-succinct book #337

Merged
merged 4 commits into from
Jan 21, 2025
Merged

docs: improve op-succinct book #337

merged 4 commits into from
Jan 21, 2025

Conversation

fakedev9999
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Metric Value
Batch Start 22,809,330
Batch End 22,809,335
Witness Generation (seconds) 52
Execution Duration (seconds) 69
Total Instruction Count 3,139,125,807
Oracle Verify Cycles 353,431,178
Derivation Cycles 2,332,423,813
Block Execution Cycles 313,142,931
Blob Verification Cycles 142,535,642
Total SP1 Gas 0
Number of Blocks 5
Number of Transactions 33
Ethereum Gas Used 11,599,881
Cycles per Block 627,825,161
Cycles per Transaction 95,125,024
Transactions per Block 6
Gas Used per Block 2,319,976
Gas Used per Transaction 351,511
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 1,081,422
P256 Verify Cycles 0

ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani reviewed Jan 20, 2025
View reviewed changes
ratankaliani
ratankaliani approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Add periods to the end of statements + include the language suggested and then the PR LGTM.

@fakedev9999
docs: apply comments
c6a7686
@fakedev9999
docs: update link to programs
94512cf 
To fixs `Linking outside of the "root" directory is forbidden`
error.
@fakedev9999
docs: ignore mdbook check for links
4cc8d5a 
`File not found` error occurs. Link with relative path, but
ignore `Linking outside of the "root" directory is forbidden`.
@fakedev9999 fakedev9999 merged commit afae216 into main Jan 21, 2025
9 checks passed
@fakedev9999 fakedev9999 deleted the taehoon/improve-docs branch January 21, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fakedev9999 @ratankaliani