fix(fault_proof): fix defend logic #411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the
get_oldest_game_address
function to accept a parameter that determines whether to check for equality or inequality between the output root and the claim.Problem
The
get_oldest_game_address
function is used for both defense (get_oldest_defensible_game_address) and challenging (get_oldest_challengable_game_address).For challenging, we should challenge games where the claimed root doesn't match the actual output root (the current logic is correct for this)
For defending, we should defend games where the claimed root does match the actual output root (the current logic is incorrect for this)
So for defense, we want the opposite condition:
if output_root == game_claim
. This would mean we're defending games where the claim is correct but a challenge occurred.