Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding classes to block.js #2635

Closed
wants to merge 3 commits into from
Closed

adding classes to block.js #2635

wants to merge 3 commits into from

Conversation

kushal-khare-official
Copy link
Contributor

Part of issue #2629

@kushal-khare-official
Copy link
Contributor Author

After hiding whitespace changes, its only 14 changed lines now

meganindya
meganindya requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 2e8627d. What you've done isn't the proper way.

@meganindya
Copy link
Member

Observe my number of lines changed vs yours. If you've followed the same approach in all your files, they've all unfortunately become useless.

@meganindya
Copy link
Member

The key was to use regular expression (REGEX) during the replacements. Before you take up some big changes, ask questions about it. You don't want your efforts to go down.

@meganindya
Copy link
Member

I'm closing this.

@meganindya meganindya closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganindya meganindya meganindya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushal-khare-official @meganindya