Merge pull request #4586 from sul-dlss/refactor-redundant-condition

Remove redundant logic in form helper
sul-dlss · Mar 3, 2025 · 1398372 · 1398372
2 parents 29bb00c + 0aa1853
commit 1398372
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/helpers/feedback_form_helper.rb b/app/helpers/feedback_form_helper.rb
@@ -13,13 +13,12 @@ def show_feedback_form?
 
   def show_quick_report?
     (params[:controller] == 'catalog' && params[:action] == 'show') or
-      (refered_from_catalog_show? &&
-        params[:controller] == 'feedback_forms' && params[:action] == 'new') || false
+      (refered_from_catalog_show? && params[:controller] == 'feedback_forms' && params[:action] == 'new')
   end
 
   def refered_from_catalog_show?
     if request.referer.present?
-      /(\/catalog\/|\/view\/)/.match?(request.referer) || false
+      /(\/catalog\/|\/view\/)/.match?(request.referer)
     end
   end
 end